Add JUnit test for Day007.class #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
|
Hi @hbelmiro, I'm quoting you to see my pull request 😄 |
hbelmiro
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Thank you for this contribution @Viniberaldo.
The idea is to replace the existing code with tests. So, you need to move the example to the test and remove the original class.
Also, since we'll use tests, we can change the example to not print the formatted message. In the original code, I've printed it to the console so people can see the result. Now that we'll have a test, the test itself is the verification. So all the boilerplate you had to add to verify the output can be removed.
See what I did here, for example: https://github.com/hbelmiro/100DaysOfJava/pull/62/files
days/day007/src/test/java/com/thegreatapi/ahundreddaysofjava/day007/Day007Test.java
Outdated
Show resolved
Hide resolved
days/day007/src/main/java/com/thegreatapi/ahundreddaysofjava/day007/Day007.java
Outdated
Show resolved
Hide resolved
Viniberaldo
force-pushed
the
day007-test
branch
from
f894dec to
44031ad
Compare
hbelmiro
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Thank you @Viniberaldo. Looks way better now.
I left a few more comments.
days/day007/src/main/java/com/thegreatapi/ahundreddaysofjava/day007/Day007.java
Show resolved
Hide resolved
days/day007/src/test/java/com/thegreatapi/ahundreddaysofjava/day007/Day007Test.java
Outdated
Show resolved
Hide resolved
days/day007/src/test/java/com/thegreatapi/ahundreddaysofjava/day007/Day007Test.java
Outdated
Show resolved
Hide resolved
… and removes the Day007 class and its directory. Key changes: Created Day007Test.java in src/test/java/com/thegreatapi/ahundreddaysofjava/day007 Removed the Day007 class and its directory Added a single test method "shouldFormatMessageCorrectly()" to test the showMessage() method Implemented the test using JUnit 5 and AssertJ for more readable assertions The test verifies that the showMessage() method correctly formats the message using MessageFormat. Benefits: Ensures proper formatting of the message Provides confidence in the correctness of the showMessage() method Please review the test implementation and provide feedback if needed.
… and removes the Day007 class and its directory.
Key changes:
Created Day007Test.java in src/test/java/com/thegreatapi/ahundreddaysofjava/day007
Removed the Day007 class and its directory
Added a single test method "shouldFormatMessageCorrectly()" to test the showMessage() method
Implemented the test using JUnit 5 and AssertJ for more readable assertions
The test verifies that the showMessage() method correctly formats the message using MessageFormat.
Benefits:
Ensures proper formatting of the message
Provides confidence in the correctness of the showMessage() method
Please review the test implementation and provide feedback if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new JUnit test class (Day007Test.java) to verify the functionality of the Day007 class.
Key changes:
The test verifies that the showMessage() method correctly formats the message using MessageFormat.
Benefits:
Please review the test implementation and provide feedback if needed.