Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This pull request introduces a new JUnit test class (Day007Test.java) and removes the Day007 class and its directory. #183

Merged
merged 1 commit into from
Oct 7, 2024
Merged

This pull request introduces a new JUnit test class (Day007Test.java) and removes the Day007 class and its directory. #183

merged 1 commit into from
Oct 7, 2024

Conversation

Viniberaldo
Copy link
Contributor 

Key changes:

Created Day007Test.java in src/test/java/com/thegreatapi/ahundreddaysofjava/day007
Removed the Day007 class and its directory
Added a single test method "shouldFormatMessageCorrectly()" to test the showMessage() method
Implemented the test using JUnit 5 and AssertJ for more readable assertions
The test verifies that the showMessage() method correctly formats the message using MessageFormat.

Benefits:

Ensures proper formatting of the message
Provides confidence in the correctness of the showMessage() method

Please review the test implementation and provide feedback if needed.

@Viniberaldo
This pull request introduces a new JUnit test class (Day007Test.java)…
6d78419 
… and removes the Day007 class and its directory.

    Key changes:

    Created Day007Test.java in src/test/java/com/thegreatapi/ahundreddaysofjava/day007
    Removed the Day007 class and its directory
    Added a single test method "shouldFormatMessageCorrectly()" to test the showMessage() method
    Implemented the test using JUnit 5 and AssertJ for more readable assertions
    The test verifies that the showMessage() method correctly formats the message using MessageFormat.

    Benefits:

    Ensures proper formatting of the message
    Provides confidence in the correctness of the showMessage() method

    Please review the test implementation and provide feedback if needed.
hbelmiro
hbelmiro approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Viniberaldo.

@hbelmiro hbelmiro linked an issue Oct 7, 2024 that may be closed by this pull request
JUnit test for Day007.class #180
Closed
@hbelmiro hbelmiro merged commit 0bbaa2f into hbelmiro:main Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JUnit test for Day007.class
2 participants
@Viniberaldo @hbelmiro