Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 update model attributes #34

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

32 update model attributes #34

wants to merge 22 commits into from

Conversation

emrdagkusu
Copy link
Collaborator

This merge request consists of the followings:

  • Model review and restructuring models
  • Unit / integration tests
  • FastAPI and Pydantic validation tricks for models
  • New validations and tests
  • Updating university section logic, attendance logic

closes #10 #14 #21 #29 #30 #31 #32

emrdagkusu and others added 18 commits March 6, 2022 19:58
@emrdagkusu
add changes of user and university models
b390f6c
@emrdagkusu
update university models and lesson section logic
d54f354
@emrdagkusu
update semester start hour
cda1ba5
@emrdagkusu
update section logic from integer list to model
6cb69e0
@emrdagkusu
remove id from section slots
6ca7c18
@emrdagkusu
update slot and absence logic
947db65 
put absences into slots to be able to relate absence with slots
@emrdagkusu
sort absences while adding
31e8f4f
@emrdagkusu
update slot order while adding/updating slots
a307d5c
@emrdagkusu
update order of sections and slots while adding/updating sections
5a8c346
@emrdagkusu
do not let creating new university lesson with same code
54491b8
@emrdagkusu
add new attriubutes and routers to user and semester
e3f8fd7
@emrdagkusu
add router for updating universities with new attributes
26cc8ec
@emrdagkusu
update model for admin user
92f3570
@emrdagkusu
update university tests after changing model attributes
42a7f63
@shiny-apricot
add user/semester and user/user router tests
8d56af0
@shiny-apricot
Add user/lesson tests.
cda647a
@shiny-apricot
Add user/slot_routers tests.
f8d043b
@emrdagkusu
let empty room for slots
88a3d55
This was linked to issues Mar 17, 2022
Unit/Integration Tests #14
Open
Append new validations for the endpoints and write tests for them. #29
Open
Updating university section logic #30
Open
Updating attendance logic #31
Open
Updating attributes of models #32
Open
Model review and restructuring some models #21
Open
shiny-apricot
shiny-apricot previously requested changes Mar 17, 2022
View reviewed changes
backend/app/models/uni_models.py Show resolved Hide resolved
@emrdagkusu
let fields in update models optional
0e20779 
in update model, fields are optional anymore. thus, it is not required to give old values to update a model
shiny-apricot
shiny-apricot approved these changes Mar 20, 2022
View reviewed changes
Copy link
Collaborator

@shiny-apricot shiny-apricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiny-apricot shiny-apricot shiny-apricot approved these changes

@hbusul hbusul Awaiting requested review from hbusul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@emrdagkusu @shiny-apricot