Move inner pushes (#6364)

hcengineering · Aug 21, 2024 · e02d0c7 · e02d0c7
1 parent 5f795ce
commit e02d0c7
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 2 deletions.
diff --git a/packages/ui/src/components/notifications/Notification.svelte b/packages/ui/src/components/notifications/Notification.svelte
@@ -20,6 +20,7 @@
   }
 
   onDestroy(() => {
+    removeNotificationHandler()
     if (closeTimeout && timeout) {
       clearTimeout(timeout)
     }

diff --git a/packages/ui/src/components/notifications/Notifications.svelte b/packages/ui/src/components/notifications/Notifications.svelte
@@ -9,13 +9,15 @@
     'top-left': NotificationPosition.TopLeft,
     'top-right': NotificationPosition.TopRight
   }
+
+  const maxVisibleNotifications = 3
 </script>
 
 <slot />
 <div class="notifications">
   {#each Object.entries(positionByClassName) as [className, position]}
     <div class={className} style:z-index={9999}>
-      {#each $store as notification (notification.id)}
+      {#each $store.slice(0, maxVisibleNotifications) as notification (notification.id)}
         {#if notification.position === position}
           <Notification {notification} />
         {/if}

diff --git a/packages/ui/src/utils.ts b/packages/ui/src/utils.ts
@@ -110,7 +110,7 @@ export function addNotification (
     title,
     subTitle,
     severity,
-    position: NotificationPosition.BottomRight,
+    position: NotificationPosition.TopRight,
     component,
     closeTimeout,
     params

diff --git a/qms-tests/sanity/storage-dev.json b/qms-tests/sanity/storage-dev.json
@@ -27,6 +27,10 @@
         {
           "name": "flagOpenInDesktopApp",
           "value": "true"
+        },
+        {
+          "name": "#platform.notification.timeout",
+          "value": "0"
         }
       ]
     }

diff --git a/qms-tests/sanity/storage.json b/qms-tests/sanity/storage.json
@@ -27,6 +27,10 @@
         {
           "name": "flagOpenInDesktopApp",
           "value": "true"
+        },
+        {
+          "name": "#platform.notification.timeout",
+          "value": "0"
         }
       ]
     }

diff --git a/qms-tests/sanity/storageQaraManager.json b/qms-tests/sanity/storageQaraManager.json
@@ -27,6 +27,10 @@
         {
           "name": "flagOpenInDesktopApp",
           "value": "true"
+        },
+        {
+          "name": "#platform.notification.timeout",
+          "value": "0"
         }
       ]
     }

diff --git a/qms-tests/sanity/storageSecond-dev.json b/qms-tests/sanity/storageSecond-dev.json
@@ -27,6 +27,10 @@
         {
           "name": "flagOpenInDesktopApp",
           "value": "true"
+        },
+        {
+          "name": "#platform.notification.timeout",
+          "value": "0"
         }
       ]
     }

diff --git a/qms-tests/sanity/storageSecond.json b/qms-tests/sanity/storageSecond.json
@@ -27,6 +27,10 @@
         {
           "name": "flagOpenInDesktopApp",
           "value": "true"
+        },
+        {
+          "name": "#platform.notification.timeout",
+          "value": "0"
         }
       ]
     }