Skip to content

Commit

Permalink
Merge pull request #1923 from headlamp-k8s/remove-secrets
Browse files Browse the repository at this point in the history
github: Remove permission that does not work
  • Loading branch information
yolossn authored Apr 23, 2024
2 parents 400746d + 2d62eb2 commit da17c33
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 9 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/app-artifacts-mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
runs-on: macos-latest
permissions:
contents: read
secrets: read
actions: write # needed to upload artifacts
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -71,7 +70,6 @@ jobs:
permissions:
id-token: write # For fetching an OpenID Connect (OIDC) token
contents: read
secrets: read
runs-on: windows-latest
needs: build-mac
if: ${{ inputs.signBinaries }}
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/docker-extension-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
build_and_push_docker_extension:
name: Build docker extension
runs-on: ubuntu-latest
permissions:
secrets: read # needed to fetch docker hub creds
steps:
- name: Login to DockerHub
uses: docker/login-action@v1
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pr-to-update-homebrew.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
permissions:
contents: write # needed to push a branch
pull-requests: write # needed to open a pull request
secrets: read

steps:
- name: Checkout headlamp repo
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/trigger-flatpak-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ jobs:
trigger_flatpak_update:
name: Trigger Flatpak Headlamp version update
runs-on: ubuntu-latest

permissions:
secrets: read # needed to fetch gh token

steps:
- name: Trigger via gh
env:
Expand Down

0 comments on commit da17c33

Please sign in to comment.