Merge pull request #2164 from headlamp-k8s/fix-tests

Makefile: github/workflows/frontend: Add i18n-check to CI

.github/workflows/frontend.yml

@@ -78,6 +78,10 @@ jobs:
         run: |
           make frontend-test
 
+      - name: Run frontend-i18n-check
+        run: |
+          make frontend-i18n-check
+  
   build:
     name: build
     runs-on: ${{ matrix.os }}

Makefile

@@ -109,6 +109,11 @@ frontend-fixlint:
 frontend-tsc:
 	cd frontend && npm run tsc
 
+.PHONY: frontend-i18n-check
+frontend-i18n-check:
+	@echo "Checking translations. If this fails use: 'npm run i18n'"
+	cd frontend && npm run i18n -- --fail-on-update
+
 frontend-test:
 	cd frontend && npm run test -- --coverage
 

frontend/src/i18n/index.test.ts

@@ -1,13 +1,10 @@
-import { execSync } from 'child_process';
 import { error } from 'console';
 import fs from 'fs';
 import * as glob from 'glob';
 
 const path = require('node:path');
 const allowlist = require('./allowlist.json');
 
-const frontendDir = path.join(__dirname, '..', '..');
-
 /*
  * Description:
  * This test will check for duplicate keys in the translation files and will fail if any are found.
@@ -120,17 +117,3 @@ describe('Test for non-intentional repeating translation keys', () => {
     expect(result).toBe(true);
   });
 });
-
-function getTranslationChanges() {
-  // Get uncommitted changes in the tracked translation files.
-  return execSync(
-    `git status -uno --porcelain ${frontendDir}/src/i18n/locales/*/*.json`
-  ).toString();
-}
-
-describe('Forgotten translations', () => {
-  test('Check uncommitted translations', async () => {
-    execSync('npm run i18n', { cwd: frontendDir });
-    expect(getTranslationChanges()).toBe('');
-  });
-});