Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins endlessly reloading on dev only app #1937

Closed
skoeva opened this issue Apr 29, 2024 · 1 comment · Fixed by #1939
Closed

Plugins endlessly reloading on dev only app #1937

skoeva opened this issue Apr 29, 2024 · 1 comment · Fixed by #1939
Assignees
Labels
backend Issues related to the backend plugins

Comments

@skoeva
Copy link
Contributor

skoeva commented Apr 29, 2024

running npm run dev-only-app locally with the .plugins directory in headlamp causes a loop of checks for updates to the plugins. deleting this directory fixes the issue though.
Screenshot 2024-04-29 111907
image

@joaquimrocha
Copy link
Collaborator

I don't think we need to watch for changes in the static-plugins folder, so we should just remove that from the watch list.

@joaquimrocha joaquimrocha added backend Issues related to the backend plugins labels Apr 29, 2024
@skoeva skoeva self-assigned this Apr 29, 2024
@skoeva skoeva linked a pull request Apr 29, 2024 that will close this issue
4 tasks
skoeva added a commit that referenced this issue Apr 29, 2024
This fix prevents the development app (when running npm run dev-only-app) from watching for static plugins locally, which causes an endless loop of refreshes to the app.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>

backend: plugins: Remove .plugins from watch list

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>

fixed error

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Apr 29, 2024
This fix prevents the development app (when running npm run dev-only-app) from watching for static plugins locally, which causes an endless loop of refreshes to the app.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue May 1, 2024
This fix prevents the development app (when running npm run dev-only-app) from watching for static plugins locally, which causes an endless loop of refreshes to the app.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue May 2, 2024
This fix prevents the development app (when running npm run dev-only-app) from watching for static plugins locally, which causes an endless loop of refreshes to the app.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue May 2, 2024
This fix prevents the development app (when running npm run dev-only-app) from watching for static plugins locally, which causes an endless loop of refreshes to the app.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue May 2, 2024
This fix prevents the development app (when running npm run dev-only-app) from watching for static plugins locally, which causes an endless loop of refreshes to the app.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue May 2, 2024
This fix prevents the development app (when running npm run
dev-only-app) from watching the .plugins directory locally, which causes
an endless loop of refreshes to the app. To do this, we ensure that
.plugins is not set as the plugins dir by default.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue May 7, 2024
This fix prevents the development app (when running npm run
dev-only-app) from watching the .plugins directory locally, which causes
an endless loop of refreshes to the app. To do this, we ensure that
.plugins is not set as the plugins dir by default.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 26, 2024
This fix prevents the development app (when running npm run
dev-only-app) from watching the .plugins directory locally, which causes
an endless loop of refreshes to the app. To do this, we ensure that
.plugins is not set as the plugins dir by default.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues related to the backend plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants