Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: config: Change default plugins dir #1939

Merged
merged 1 commit into from
May 8, 2024
Merged

backend: config: Change default plugins dir #1939

merged 1 commit into from
May 8, 2024

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Apr 29, 2024 •
edited
Loading

This fix prevents the development app (when running npm run dev-only-app) from watching the .plugins directory locally, which causes an endless loop of refreshes to the app. To do this, we ensure that .plugins is not set as the plugins dir by default.

Fixes: #1937

Testing

  • Create .plugins folder locally (e.g. by running make app-linux)
  • Run make run-frontend, make run-backend and npm run dev-only-app
  • Ensure that "Plugins are loaded" message is only outputted once by the app
  • Ensure that the backend does not send "Sending reload plugins signal to frontend" in a loop

@skoeva skoeva linked an issue Apr 29, 2024 that may be closed by this pull request
Plugins endlessly reloading on dev only app #1937
Closed
@skoeva skoeva self-assigned this Apr 29, 2024
@skoeva skoeva added backend Issues related to the backend plugins labels Apr 29, 2024
@skoeva skoeva force-pushed the remove-static-plugins branch 2 times, most recently from 3f9f4f5 to edc1871 Compare April 29, 2024 21:37
@skoeva skoeva marked this pull request as ready for review April 29, 2024 21:38
joaquimrocha
joaquimrocha requested changes Apr 30, 2024
View reviewed changes
backend/pkg/plugins/plugins.go Outdated Show resolved Hide resolved
@skoeva skoeva force-pushed the remove-static-plugins branch 4 times, most recently from 1db620e to af516e3 Compare May 2, 2024 20:52
@skoeva skoeva changed the title backend: plugins: Remove .plugins from watch list backend: config: Change default plugins dir May 2, 2024
@skoeva skoeva force-pushed the remove-static-plugins branch from af516e3 to a6860fe Compare May 2, 2024 21:10
@skoeva
backend: config: Change default plugins dir
e0b66e5 
This fix prevents the development app (when running npm run
dev-only-app) from watching the .plugins directory locally, which causes
an endless loop of refreshes to the app. To do this, we ensure that
.plugins is not set as the plugins dir by default.

Fixes: #1937

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva skoeva force-pushed the remove-static-plugins branch from 48eb805 to e0b66e5 Compare May 7, 2024 18:19
@joaquimrocha joaquimrocha self-requested a review May 8, 2024 15:04
@joaquimrocha joaquimrocha merged commit c03ca0b into main May 8, 2024
11 checks passed
@joaquimrocha joaquimrocha deleted the remove-static-plugins branch May 8, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

Assignees

@skoeva skoeva

Labels
backend Issues related to the backend plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugins endlessly reloading on dev only app
2 participants
@skoeva @joaquimrocha