-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Add create namespace ui #1727
Conversation
4840332
to
9304a84
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for translations
4103f4e
to
c199d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vincent.
Can you move the dialog/button into its own module? So it's more isolated and also in case we want to show it in a different view.
For consistency with the rest of the UX, I think the create button should trigger a cancellable action (like the Editor's apply / Delete / Scale / etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Req changes.
d626eb9
to
564b556
Compare
|
last push
|
564b556
to
763ae21
Compare
maybe artificially adding a timer would allow it to be slow enough to react to a quit action? |
486fc30
to
3e9fd01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Left a few comments after trying it out.
Seems also like some storybook snapshots that are unrelated did get updated. So I am not sure if it's a legitimate side-effect or if we're now breaking the snapshot generation with this addon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by mistake. I meant it needs changes.
4e31e2e
to
b733add
Compare
Still can't seem to source that build error? |
37d4fcc
to
8fddbd4
Compare
rebased to current main and updated the |
47fac1a
to
5ff103e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Found a few things in the code.
857ab27
to
b866e3c
Compare
0059fff
to
37970b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last change needed.
Signed-off-by: Vincent T <vtaylor@microsoft.com>
37970b7
to
688ae64
Compare
Add Create Namespace Feature to UI
fixes #1705
fixes #2055
Description
This PR introduces a new feature to the UI that allows users to create namespaces directly from the namespaces list view. A 'Create' button (represented by a + sign) has been added next to the title of the namespaces list view. Upon clicking this button, users are presented with a dialog box where they can input the name for the new namespace. Submitting this by clicking the 'Create' button will create the new namespace.
Changes
Verification
Screenshots