Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend cluster/Overview: Show only warnings by default #1873

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

joaquimrocha
Copy link
Collaborator

@joaquimrocha joaquimrocha commented Mar 26, 2024

By default we should show only warnings. This wrong default has been
around since we added the related switch.

@joaquimrocha joaquimrocha requested a review from illume March 26, 2024 16:01
@joaquimrocha joaquimrocha added frontend Issues related to the frontend bug Something isn't working labels Mar 26, 2024
@joaquimrocha joaquimrocha added this to the v0.23.1 milestone Mar 26, 2024
@illume
Copy link
Collaborator

illume commented Mar 26, 2024

test snapshots need updating

By default we should show only warnings. This wrong default has been
around since we added the related switch.

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha joaquimrocha force-pushed the show-only-warnings-events-by-default branch from 6bcfd3c to 2cc2b17 Compare March 26, 2024 17:00
Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@illume illume merged commit 24f2322 into main Mar 26, 2024
9 checks passed
@illume illume deleted the show-only-warnings-events-by-default branch March 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Issues related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants