Plugin Catalog prerequisites #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yolossn I guess you saw these app CI failures? https://github.com/headlamp-k8s/headlamp/actions/runs/8662622201/job/23754940075?pr=1907#step:5:237 They look like real failures. About some module missing. |
illume
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Nice one, thank you.
There's some error in the app CI job about a missing module.
I left a few notes...
Additionally,
- please add some tests? (maybe they could go in with the existing tests... but perhaps because they run quickly, and the existing tests are a bit clumbsy because they try to avoid a lot of extra installations, it would be better to have a separate set of tests for some of these commands using jest?)
- please update the README with the new commands next to the existing ones? Maybe add a section on how that binary is different.
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
illume
reviewed
Apr 12, 2024
yolossn
force-pushed
the
plugin_store
branch
5 times, most recently
from
e8eec01 to
9d72132
Compare
joaquimrocha
previously requested changes
Apr 16, 2024
yolossn
force-pushed
the
plugin_store
branch
6 times, most recently
from
d676012 to
48518cf
Compare
yolossn
force-pushed
the
plugin_store
branch
3 times, most recently
from
584b09d to
d536d41
Compare
illume
reviewed
Jul 1, 2024
yolossn
force-pushed
the
plugin_store
branch
2 times, most recently
from
d32ed7d to
c2f8f0b
Compare
this patch adds PluginManager class that has functions to install, update,uninstall and list plugins Signed-off-by: yolossn <sannagaraj@microsoft.com>
Signed-off-by: yolossn <sannagaraj@microsoft.com>
this patch adds PluginManagerEventListeners class that sets up the event handlers for the plugin manager events. Signed-off-by: yolossn <sannagaraj@microsoft.com>
this commit adds PluginManager class to handle plugin installation,update,uninstallation and listing, the class provides static methods for each operation and communicates to the electron app using the desktop API. the class also has a cancel function to cancel a running installation or update process. Signed-off-by: yolossn <sannagaraj@microsoft.com>
This patch adds the plugin management commands install,uninstall,update and list to the headlamp-plugin cli. Signed-off-by: yolossn <sannagaraj@microsoft.com>
this patch adds removeListener to desktopApi for removing the listener. Signed-off-by: yolossn <sannagaraj@microsoft.com>
yolossn
force-pushed
the
plugin_store
branch
9 times, most recently
from
71c03be to
ae89224
Compare
This patch adds integration test for plugin management commands. Signed-off-by: yolossn <sannagaraj@microsoft.com>
yolossn
commented
Jul 1, 2024
|
(added issue to PR description) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
plugin-management.jsfile has been introduced, responsible for handling plugin installation, listing, upgrades, and deletions. Additionally, therunCommandfunction has been enhanced to support electron-node command, enabling seamless execution of Node commands within the Electron environment.For #1654