charts: add ingressClassName to ingress template #1932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the existing ingress chart template and adds the field "ingress.ingressClassName".
According to the kubernetes documentation, setting the ingressClassName in the annotations is deprecated: https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation
This fixes issue #1895
Changes
Added one line to the ingress chart template to template the field
Values.ingress.ingressClassName
if it existsVerification
I tested the change locally by defining a simple my-values.yaml file:
Using
helm template
I confirmed that a correct Ingress was templated:Results in: