WIP: frontend: router: Add lazy loading of routes for code splitting #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Splitting on every route might be an overkill imho, usually it's only needed in components that import big libraries (for example EditorDialog that imports monaco would be good case for lazy loading). Otherwise it'll just generate a lot of small chunks which might negatively impact build time |
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Because they are not used in many modules, and so they should not be loaded all the time by putting them in the common/index. Additionally, this means that the code is only loaded when the pod details route is loaded. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This speeds up the development server when making changes. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This works with Windows, because before setting environment variables did not work when using cmd or powershell. Also use nice -19 to speed things up on WSL a lot. Because in a VM it can be twice as slow normally. It's only getting priority when compiling, so that is usually what we want. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.