-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Refactor KubeObject class #1967
Conversation
621b07d
to
0653be0
Compare
7a5511b
to
62a9c07
Compare
This is ready for review. |
1dea316
to
a6d2baf
Compare
c6ccfbd
to
e4ad952
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about something I found. Also needs rebasing now.
0b1f1fc
to
28733b1
Compare
I've managed to refactor types a bit to avoid CodeQL hanging (it's not as pretty but works) |
6a1e482
to
92b9596
Compare
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
…formation Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
This PR refactors KubeObject class and how we define different Kubernetes resources.
Resource classes will now:
KubeObject currently resolves to any. So everywhere KubeObject was used there's no type safety.
objectName
kind
apiName
isNamespaced
andapiVersion
fieldsapiFactory
, it will automatically made based on the class fieldsThis PR makes KubeObject a class that's available outside of makeKubeObject (deprecated) function
Summary of the changes
This PR also fixes all the type errors that were surfaced by KubeObject not resolving to
any