Add enhancement to rename cluster

[knrt10]

This adds feature where user can now use renamed cluster name in their UI.

Fixes: #1653

Testing

• Remove old kubeconfig rm ~/.config/Headlamp/kubeconfigs/config
• Run app cd app && npm run dev-only-app
• Run backend with stateless clusters enabled cd backend && go run ./cmd -dev -enable-dynamic-clusters
• Go to cluster settings and there is option for user to rename their cluster

Screenshots

TODO

• Add for stateless clusters
• Add tests

[joaquimrocha]

So I swear I had sent a message here with some screenshots showing some problems but I don't see the message now...
Anyway, I pushed some changes to make the UI hopefully nicer + restrict it to electron only (this is important!), and I have also verified that some of the problems I had which made me think we shouldn't add this to the 0.24.0 release were in a past iteration of this branch.
Now things seem to work fine, though it looks like if I switch between the default cluster name and the new one, in the settings it shows me the previous name (not sure if this is autocomplete getting in the way).

Anyway, here is how it looks now (notice how the error status no longer extends the input till the end of the space):

[joaquimrocha]

@illume What do you think? Should try to add it for 0.24.0 or should we move it (keep it now, since I had changed the milestone when I was in the outdated branch) to 0.25.0?

[illume]

👍 thanks

[illume]

@knrt10

Seems the text is wrong after I change it, then change it back.

• click 'minikube' cluster and cluster settings
• change 'minikube' to 'mycluster'
• change back to 'minikube'
• click cluster, and cluster settings... it says 'mycluster' still in the input text.

See in the minikube cluster but the text has the old 'mycluster' there. It should be 'minikube' or empty.

[illume]

I had a look around for the bug a little bit, but couldn't find it.

Probably we should add some tests, and perhaps refactor SettingsCluster a bit.

[illume]

Maybe we should add this flag to dev mode? Or to the app?

diff --git a/Makefile b/Makefile
index 2d426825..102fd637 100644
--- a/Makefile
+++ b/Makefile
@@ -86,10 +86,10 @@ run-backend:
        @echo "**** Warning: Running with Helm and dynamic-clusters endpoints enabled. ****"

 ifeq ($(UNIXSHELL),true)
-       HEADLAMP_BACKEND_TOKEN=headlamp HEADLAMP_CONFIG_ENABLE_HELM=true HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true ./backend/headlamp-server -dev -proxy-urls https://artifacthub.io/*
+       HEADLAMP_BACKEND_TOKEN=headlamp HEADLAMP_CONFIG_ENABLE_HELM=true HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true ./backend/headlamp-server -dev -proxy-urls https://artifacthub.io/* -enable-dynamic-clusters
 else
        @echo "**** Running on Windows without bash or zsh. ****"
-       @cmd /c "set HEADLAMP_BACKEND_TOKEN=headlamp&& set HEADLAMP_CONFIG_ENABLE_HELM=true&& set HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true&& backend\headlamp-server -dev -proxy-urls https://artifacthub.io/*"
+       @cmd /c "set HEADLAMP_BACKEND_TOKEN=headlamp&& set HEADLAMP_CONFIG_ENABLE_HELM=true&& set HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true&& backend\headlamp-server -dev -proxy-urls https://artifacthub.io/*" -enable-dynamic-clusters
 endif

 run-frontend:

[knrt10]

@illume fixed, can you please test again. Thanks

rerequested

[illume]

I'm having an issue where it's not changing...

[illume]

Ok... it works after I clear my localstorage. I think when it was broken something bad got in there.

[illume]

Thanks. 👍

[skoeva]

Works great on my end, thanks for this! 🙌