Win fixes for Makefile, and WSL speedup #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works with Windows, because before setting environment variables did not work when using cmd or powershell. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This speeds things up on WSL a lot. Because in a VM it can be 2x-3x as slow often. It's only getting priority when compiling, so that is usually what we want when running the dev server. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume
added
bug
skoeva
approved these changes
May 13, 2024
|
I have a theory that it's not Try this on main branch: but 🤔 although after trying to run strace on it I can't reproduce it anymore. strange |
|
@sniok how bizarre! I can't see that behaviour myself with the environment variable. Note, setting REACT_APP_HEADLAMP_BACKEND_TOKEN is redundant in the Makefile, since it's already set inside the "npm start" script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
In cmd shell on windows
These work again:
In WSL on windows
make run-frontendis generally faster.Save a component and note the time compiling. Over 10 times there is much less variation in timing. Whereas without this it's 2x - 3x slower often.