Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Update go helm chart dependencies and related packages #1983

Merged
merged 8 commits into from
May 20, 2024

Conversation

joaquimrocha
Copy link
Collaborator

@joaquimrocha joaquimrocha commented May 16, 2024

This also fixes a requirement for the CodeQL tool (needing a toolchain version for the go.mod).

@joaquimrocha joaquimrocha marked this pull request as ready for review May 17, 2024 13:05
@joaquimrocha joaquimrocha requested review from knrt10, illume and a team May 17, 2024 13:05
@illume
Copy link
Collaborator

illume commented May 17, 2024

I learnt about go toolchains here: https://go.dev/doc/toolchain and https://go.dev/blog/rebuild

Are there any other resources explaining this issue?

@joaquimrocha
Copy link
Collaborator Author

I learnt about go toolchains here: https://go.dev/doc/toolchain and https://go.dev/blog/rebuild

Are there any other resources explaining this issue?

I am not sure. I noticed this got added after I ran go mod tidy. Unrelatedly noticed that CodeQL was complaining that the toolchain was missing.

@illume
Copy link
Collaborator

illume commented May 17, 2024

I have go 1.22.1 locally at the moment. With this it downloads the 1.22.3 that I'm missing to do the build.

Pretty sweet!

$ make backend
cd backend && go build -o ./headlamp-server ./cmd
go: downloading go1.22.3 (linux/amd64)
go: downloading k8s.io/apimachinery v0.30.0
go: downloading k8s.io/client-go v0.30.0

Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

@joaquimrocha joaquimrocha merged commit 06eea77 into main May 20, 2024
10 checks passed
@joaquimrocha joaquimrocha deleted the update-go-deps branch May 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants