-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod/List: Fix IPs being displayed as "undefined" when not set #1994
Conversation
d30aa09
to
9019112
Compare
9019112
to
fc6578a
Compare
showed undefined for a minute when in the browser (may have been a weird pod I created or was behind on the render) but the storybook comp shows empty, current build error keeps the browser view away |
aa0d66a
to
2304f05
Compare
Rerunning the container e2e tests, which failed. |
I did some digging on this... The API reference says the status field should always be there. Could be a kubernetes bug though where the status field is missing. |
I reran the container job a few times, and it keeps failing. It's passing recently in other PRs, so I guess it's a real issue. |
The problem is that if we do not merge, then this is a real issue as it could show undefined for the IP (the state must exist but the IP could be undefined). |
This is the last one that passed the container build from this PR: https://github.com/headlamp-k8s/headlamp/actions/runs/9288417462/job/25559819347 With this commit fc6578a But I don't see any difference in the code, except for something in the storyhelper file... which should not affect the test. So... I'm pretty sure it is a temporary error with the github runners somehow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
2304f05
to
cee87c2
Compare
Just noticed that after the table changes we have pod IPs as being
undefined
(when there's no IP defined) in the pod list.How to test:
undefined
)