Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend statefulset/list: fix List view broken #1999

Closed
wants to merge 1 commit into from

Conversation

yuriscott
Copy link

I found there is a error that will crash the StateFulSet/List
`
label: t('Containers'),
getValue: statefulSet => statefulSet.containerNames.join(', '),
render: statefulSet => {

`
seem like statefulSet object has no property named 'containerNames'

So I change the code to
getValue: statefulSet => statefulSet.getContainers().map(it => it.name).join(', '),

Signed-off-by: yuri.yin <yincc8@chinatelecom.cn>
@sniok
Copy link
Contributor

sniok commented May 29, 2024

good catch, thanks!

@joaquimrocha we should include this in the upcoming release

@sniok sniok requested review from joaquimrocha and sniok May 29, 2024 09:16
@joaquimrocha
Copy link
Collaborator

@yuriscott , the CI is failing on code styling. Can you run npm run format from the frontend plugin and squash the results to your commit?

@joaquimrocha
Copy link
Collaborator

Closing in favor of #2002 . It's the same author/changes, just formatted. Thank you so much @yuriscott !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants