Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: MainInfoSection: Correctly handle null backLink #2040

Closed
wants to merge 1 commit into from
Closed

frontend: MainInfoSection: Correctly handle null backLink #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions frontend/src/components/App/Notifications/__snapshots__/List.List.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,5 @@
<div>
<button
class="MuiButtonBase-root MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeSmall MuiButton-textSizeSmall MuiButton-colorPrimary MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeSmall MuiButton-textSizeSmall MuiButton-colorPrimary css-w7fpvq-MuiButtonBase-root-MuiButton-root"
tabindex="0"
type="button"
>
<span
class="MuiButton-icon MuiButton-startIcon MuiButton-iconSizeSmall css-y6rp3m-MuiButton-startIcon"
/>
<p
class="MuiTypography-root MuiTypography-body1 css-1ezega9-MuiTypography-root"
style="padding-top: 3px;"
>
Back
</p>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>

<div
class="MuiBox-root css-j1fy4m"
>
Expand Down
19 changes: 1 addition & 18 deletions frontend/src/components/App/Settings/__snapshots__/Settings.General.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,5 @@
<div>
<button
class="MuiButtonBase-root MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeSmall MuiButton-textSizeSmall MuiButton-colorPrimary MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeSmall MuiButton-textSizeSmall MuiButton-colorPrimary css-w7fpvq-MuiButtonBase-root-MuiButton-root"
tabindex="0"
type="button"
>
<span
class="MuiButton-icon MuiButton-startIcon MuiButton-iconSizeSmall css-y6rp3m-MuiButton-startIcon"
/>
<p
class="MuiTypography-root MuiTypography-body1 css-1ezega9-MuiTypography-root"
style="padding-top: 3px;"
>
Back
</p>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>

<div
class="MuiBox-root css-j1fy4m"
>
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/components/common/Resource/MainInfoSection/MainInfoSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export function MainInfoSection(props: MainInfoSectionProps) {
const header = typeof headerSection === 'function' ? headerSection(resource) : headerSection;

function getBackLink() {
if (backLink === null) {
return false;
}

if (!!backLink || backLink === '') {
return backLink;
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/common/SectionBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function SectionBox(props: SectionBoxProps) {

return (
<>
{actualBackLink !== undefined && <BackLink to={actualBackLink} />}
{actualBackLink && <BackLink to={actualBackLink} />}
<Box py={0} {...outterBoxProps}>
{title && titleElem}
<Box
Expand Down
19 changes: 1 addition & 18 deletions frontend/src/components/crd/__snapshots__/CustomResourceDetails.NoError.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,7 @@
<div
class="MuiBox-root css-p0cik4"
>
<button
class="MuiButtonBase-root MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeSmall MuiButton-textSizeSmall MuiButton-colorPrimary MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeSmall MuiButton-textSizeSmall MuiButton-colorPrimary css-w7fpvq-MuiButtonBase-root-MuiButton-root"
tabindex="0"
type="button"
>
<span
class="MuiButton-icon MuiButton-startIcon MuiButton-iconSizeSmall css-y6rp3m-MuiButton-startIcon"
/>
<p
class="MuiTypography-root MuiTypography-body1 css-1ezega9-MuiTypography-root"
style="padding-top: 3px;"
>
Back
</p>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>

<div
class="MuiBox-root css-j1fy4m"
>
Expand Down
Loading