Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add story for MainInfoSection #2042

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

joaquimrocha
Copy link
Collaborator

Following #2034 , I am adding this story for testing the null backlink.

@joaquimrocha joaquimrocha requested a review from skoeva June 14, 2024 21:17
@joaquimrocha
Copy link
Collaborator Author

@sniok , I added this quick story for the MainInfoSection, mainly for testing the backlink. However, it looks like the story is generating changes in other snapshots. Maybe this is because I am importing the podList which comes from a different section and maybe that messes up some things?
I am mentioning you here just in case this is related to the Vite changes, since I don't remember a case like this before.

@sniok
Copy link
Contributor

sniok commented Jun 17, 2024

I'll take a look

@sniok
Copy link
Contributor

sniok commented Jun 17, 2024

There was an issue with snapshots, they were not deterministic sometimes, I made a PR with a fix.

Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, snapshot output was a bit confusing so appreciate the changes made in #2045

@sniok
Copy link
Contributor

sniok commented Jun 18, 2024

Regenerated snapshots as a fixup commit

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha joaquimrocha merged commit e0cb34a into main Jun 18, 2024
16 checks passed
@joaquimrocha joaquimrocha deleted the backlink-stories branch June 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants