Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error boundary Page link #2111

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix error boundary Page link #2111

merged 2 commits into from
Jul 18, 2024

Conversation

ashu8912
Copy link
Member

@ashu8912 ashu8912 commented Jul 1, 2024 •
edited
Loading

fixes #2109

  • Fix home link in app
  • Add an app menu to navigate home
  • Add back/forward app menus to navigate history

@ashu8912
frontend: Fix home and choose another cluster links
d8a348e 
On desktop we use hash based routing for URLs, So we need
to consider that when preparing a raw link.

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>
@ashu8912 ashu8912 force-pushed the fix-error-boundary-link branch from b370083 to 01481aa Compare July 1, 2024 06:08
@ashu8912 ashu8912 requested a review from joaquimrocha July 1, 2024 09:10
joaquimrocha
joaquimrocha requested changes Jul 1, 2024
View reviewed changes
app/electron/main.ts Outdated Show resolved Hide resolved
@ashu8912 ashu8912 force-pushed the fix-error-boundary-link branch from 01481aa to 5a7fbc0 Compare July 2, 2024 10:25
joaquimrocha
joaquimrocha requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments, which I think improve the UX.

app/electron/main.ts Outdated Show resolved Hide resolved
app/electron/main.ts Show resolved Hide resolved
app/electron/main.ts Show resolved Hide resolved
app/electron/main.ts Show resolved Hide resolved
app/electron/main.ts Show resolved Hide resolved
app/electron/main.ts Show resolved Hide resolved
@ashu8912 ashu8912 force-pushed the fix-error-boundary-link branch from 5a7fbc0 to 254ee6d Compare July 9, 2024 05:22
@illume illume added bug Something isn't working frontend Issues related to the frontend app ErrorPage ErrorPage component labels Jul 9, 2024
@ashu8912 ashu8912 requested a review from joaquimrocha July 10, 2024 06:21
joaquimrocha
joaquimrocha requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine but I think we can improve the code a bit. Please check my comments.

frontend/src/components/App/Layout.tsx Show resolved Hide resolved
app/electron/main.ts Outdated Show resolved Hide resolved
@ashu8912 ashu8912 force-pushed the fix-error-boundary-link branch from 254ee6d to 1c6b202 Compare July 15, 2024 05:32
@ashu8912 ashu8912 requested a review from joaquimrocha July 15, 2024 05:32
@ashu8912
app: Add Go To Home Screen menu under view section
61040b2 
We need a way to directly go to home screen from an app menu.

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>
@ashu8912 ashu8912 force-pushed the fix-error-boundary-link branch from 1c6b202 to 61040b2 Compare July 16, 2024 11:43
@joaquimrocha joaquimrocha added this to the v0.25.0 milestone Jul 18, 2024
@joaquimrocha joaquimrocha merged commit 21c8d95 into main Jul 18, 2024
18 checks passed
@joaquimrocha joaquimrocha deleted the fix-error-boundary-link branch July 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

Assignees
No one assigned
Labels
app bug Something isn't working ErrorPage ErrorPage component frontend Issues related to the frontend
Projects
Release Plan / Roadmap
Status: Done
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.

Home link in "uh-oh" page doesn't work in app mode
3 participants
@ashu8912 @joaquimrocha @illume