github: backend-test: Skip coverage except for PRs #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they are not used on branch builds like on main. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
So we can see which of the bash commands in a run block are failing. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume
added
bug
|
We should first merge the template fix though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, tests running from branches (not PRs) would fail in the backend coverage scripts.
testing done
I created a testing-rc- branch which triggers the CI on branch pushes. You can see the testing-rc-... branch CI run passes now: https://github.com/headlamp-k8s/headlamp/actions/runs/9760869672 Whereas before this would fail.
NOTE: the charts CI failure is unrelated. There's a PR to fix it here: #2122