frontend: Improve test coverage collection #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wait v8 coverage collector counts comments as lines. Maybe let's stick to istanbul |
sniok
force-pushed
the
coverage-improvements
branch
from
eb11de8 to
42bc7a5
Compare
illume
reviewed
Jul 5, 2024
illume
reviewed
Jul 5, 2024
sniok
force-pushed
the
coverage-improvements
branch
from
42bc7a5 to
6f5b783
Compare
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
sniok
force-pushed
the
coverage-improvements
branch
from
6f5b783 to
542cc16
Compare
illume
approved these changes
Jul 8, 2024
illume
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For coverage task in #2125
Copied coverage collection includes/excludes from previous jest setup so it's more comparable and switched to istanbul coverage provider.