Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: Dependency updates #2142

Merged
merged 26 commits into from
Jul 18, 2024
Merged

app: Dependency updates #2142

merged 26 commits into from
Jul 18, 2024

Conversation

illume
Copy link
Collaborator

@illume illume commented Jul 6, 2024 •
edited
Loading

Remove and update some app/ dependencies.

Testing done

  • each commit builds on CI
  • ran the app, did some smoke testing
  • tested pushing assets using push-release-assets.js

@illume illume closed this Jul 15, 2024
@illume illume reopened this Jul 15, 2024
@illume illume added dependencies Pull requests that update a dependency file app labels Jul 15, 2024
@illume illume force-pushed the app-deps branch 2 times, most recently from 19122ac to b17a622 Compare July 15, 2024 11:01
@illume illume marked this pull request as ready for review July 15, 2024 12:13
@illume illume added security release Related to releasing labels Jul 15, 2024
@illume illume requested a review from a team July 15, 2024 12:19
@joaquimrocha
Copy link
Collaborator

@illume I have just tested push-release-assets.js:

  1. Create a new version draft, call it e.g. v0.1234 (DO NOT PUBLISH)
  2. Run the push-release-assets.js script with any file, like node push-release-assets.js v0.123 somefile.zip

Worked fine just by moving to this branch.

@illume illume mentioned this pull request Jul 16, 2024
Closed
@illume
Copy link
Collaborator Author

illume commented Jul 16, 2024

Thanks @joaquimrocha

@illume
Copy link
Collaborator Author

illume commented Jul 16, 2024

Rebased against main, because merge conflict.

@illume illume marked this pull request as draft July 18, 2024 09:14
@illume
Copy link
Collaborator Author

illume commented Jul 18, 2024

The "Build Container" job failure is unrelated to this.

@illume illume marked this pull request as ready for review July 18, 2024 13:00
@illume
Copy link
Collaborator Author

illume commented Jul 18, 2024

I copied the plugin-management.js into the app/ and converted it to typescript. So running the built app works again.

@illume illume force-pushed the app-deps branch 2 times, most recently from 469b281 to 3e7fab4 Compare July 18, 2024 14:32
illume added 6 commits July 18, 2024 16:35
@illume
app: Bump mkdirp 3.0.1 from 1.0.4
427de32 
https://github.com/isaacs/node-mkdirp/blob/main/CHANGELOG.md

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump tar from 6.1.13 to 7.4.0
e6860cf 
https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Remove unused @types/semver
c17e76a 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump dotenv 16.0.1 to 16.4.5
3fd716a 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: frontend: Add app/tsconfig.json to formatted file list
e5e5e50 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump jest from 27.4.7 to 29.7.0
964dab3 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume added 19 commits July 18, 2024 16:36
@illume
app: Remove open dep, use builtin openExternal
5d3f380 
From open docs:
"If you need this for Electron, use shell.openPath() instead."

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump yargs 16.2.0 to 17.7.2
7f236f9 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump i18next to 23.12.1 and i18next-fs-backend to 2.3.1
1223f3b 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump i18next-parser 7.7.0 to 9.0.0
b0b26cc 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Remove electron-log dependency
1f9b506 
Much of the code already uses the built in console.log/info/error,
so just use that instead.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump electron 30.0.6 to 31.2.0
67eaf78 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Remove fs-extra dependency
59db438 
The node:fs module can do these things now itself.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump electron-wix-msi 4.0.0 to 5.1.3
bb02be8 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump @electron/notarize 2.1.0 to 2.3.2
6548e0c 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump @babel/* deps
3b8d4a1 
@babel/cli 7.15.7 to 7.24.8
@babel/core 7.24.8 to 7.24.9
@babel/preset-env 7.15.8 to 7.24.8
@babel/preset-typescript 7.15.0 to 7.24.7

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump typescript 4.5.5 to 5.5.3
e4f66d1 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: tsconfig: Bump target from "es6" to "2023"
f99233e 
Since we use a very recent chrome/electron and node we don't need
to use an old target with polyfils and such.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Remove regenerator-runtime dependency
4a12e82 
This is not needed now. The error it fixed does not appear now.

Likely fixed with a newer babel/typescript or
fixed via a newer js target for ts.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Bump octokit 2.1.0 to 4.0.2
27c96b9 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app/scripts/push-release-assets: Update for new octokit
caee63b 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: winget-create: Remove node-fetch import
f85b127 
Now node has fetch built in from 18.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
plugins: plugin-management: Remove node-fetch import
ac24703 
fetch is built into node now since 18.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Add node and npm minimum requirements
c39196d 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
app: Fix babelrc to target node 20
59844c9 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
Copy link
Collaborator Author

illume commented Jul 18, 2024

Rebased against main to fix conflict.

@illume
Copy link
Collaborator Author

illume commented Jul 18, 2024

Fixed a lint issue.

@illume
app: Add plugin-management and convert to ts
855c279 
Because there were errors when importing from outside of tree in
the app builds.

This is temporary into a better solution can be done for sharing
this code between headlamp-plugin and app.

Had to remove env-paths usage because it wasn't working in when
running the build of the app.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@joaquimrocha joaquimrocha merged commit 6051001 into main Jul 18, 2024
17 of 18 checks passed
@joaquimrocha joaquimrocha deleted the app-deps branch July 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

Assignees
No one assigned
Labels
app dependencies Pull requests that update a dependency file release Related to releasing security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illume @joaquimrocha