Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin catalog extras #2148

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Plugin catalog extras #2148

merged 3 commits into from
Jul 9, 2024

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented Jul 8, 2024

This patch adds few extra changes that are required for the plugin catalog plugin.

  1. Add extra meta to installed plugins
  2. Add user confirmation dialog to plugin Install
  3. Add pluginName arg to pluginManager install function.

For #1654

yolossn added 3 commits July 9, 2024 00:09
this patcha adds extra meta to plugin install and
list author and repoName in list response

Signed-off-by: yolossn <sannagaraj@microsoft.com>
this patch adds a user confirmation dialog to the
plugin install handler

Signed-off-by: yolossn <sannagaraj@microsoft.com>
this patch adds pluginName to the plugin managers
install function

Signed-off-by: yolossn <sannagaraj@microsoft.com>
@yolossn yolossn force-pushed the plugin_catalog_extras branch from 95d66df to 2543c95 Compare July 8, 2024 18:39
@yolossn yolossn requested review from joaquimrocha and illume July 8, 2024 18:53
Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@illume illume merged commit efc166f into main Jul 9, 2024
18 checks passed
@illume illume deleted the plugin_catalog_extras branch July 9, 2024 12:58
@illume illume added bug Something isn't working security plugins labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugins security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants