-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Use multiple queries in useKubeObjectList and add support for allowedNamespaces #2486
Conversation
bb75a31
to
732ba00
Compare
Tested and works fine:
|
88ffb44
to
a816a4e
Compare
Extracted some logic to a function and added unit tests for it |
1f096f4
to
56cea3d
Compare
@vyncent-t @skoeva and I are giving this a test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed the first three commits and left some comments
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
I've found a bug here, working on a fix |
56cea3d
to
b659dcf
Compare
…nections at once Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
b659dcf
to
c60fafb
Compare
It was recreating connections way too often. Now it's working as expected Tested by updating a deployment and making sure /deployment and /pods websockets are not recreated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Left a few notes about the third commit.
Additionally, the third commit message could use some more detail.
Tested the allowedNamespaces again and it's still working. |
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
c60fafb
to
6b4d7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
Create a kubeObjectListQuery, for a singular request
useKubeObjectList can handle multiple clusters and namespaces by using multiple queries
_useKubeObjectList and _useKubeObjectLists are no longer neccessary since useKubeObjectList can handle 1 and more lists
Manual testing done: