-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: ClusterNotFoundPopup: Fix to work with multi clusters #2512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this show a popup per cluster? I think this UX could be unnerving for the user. I had actually disabled the popup when in multi-cluster.
c42f7b2
Can't remember exactly but I think I had tried to add the cluster problems in the main view, to be expanded at will.
I don't think completely disabling the alert is a good idea. It's most likely every single cluster won't break at the same time. How about:
|
@joaquimrocha please respond to this comment? #2512 (comment) |
Okay. Let's try this. If it gets unnerving, we can act on that. |
948359b
to
60333ac
Compare
Solved a conflict it had. |
60333ac
to
f4f512f
Compare
I made it so only a maximum of only two alerts will be shown. |
Now when there's a wrong cluster name in the URL when using multiple clusters it also gives a cluster not found alert message for each cluster not found. NOTE: A maximum of only two alerts will be shown. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
f4f512f
to
3812f0f
Compare
rebased against main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Lgtm. Thanks
change to limit maximum number of alerts was done
Now when there's a wrong cluster name in the URL when using multiple clusters it also gives a cluster not found alert message for each cluster not found.
NOTE: A maximum of only two alerts will be shown.
How to test