-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - frontend: PluginSettings: Refactor local storage and plugin data #2671
base: main
Are you sure you want to change the base?
Conversation
005cabd
to
d2f8668
Compare
Last push adds backwards comp so that all settings wont be set to off or on |
I have tried to keep the changes as small as possible to accomplish everything it needs to, I am not using the map object to save information anymore, although to hit these targets I still had to use most of what I had reworked previously for this PR the targets it needs to hit were:
The plugin data comes from the backend, reused the same method of reaching it from the previous rework
The data is now trimmed down to just being the name and isEnabled, it is now being used the same way as the original settings where this local saved item is how new app start ups save plugin settings
The local storage handling logic checks for the old format and changes it to the new format |
d2f8668
to
56e912f
Compare
56e912f
to
c150408
Compare
Some things to do to avoid duplicating of logic:
|
c150408
to
83f279e
Compare
Signed-off-by: Vincent T <vtaylor@microsoft.com>
83f279e
to
98c1b58
Compare
This is the rework for the local storage plugin settings usage
This PR shrinks the saved JSON data from the plugins information and saves only the name and isEnabled in the local storage, this is what allows the plugin settings to be saved when closing and starting the app again
This PR also handles backwards compatibility that allows previous settings saved to be used in this new format
This PR also no longer takes old information stored in the JSON of the local storage and instead takes it from the backend when the main Plugin component is called