Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Improve scroll bars #2715

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

frontend: Improve scroll bars #2715

wants to merge 4 commits into from

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Dec 19, 2024 •
edited
Loading

These changes display the scroll bars for the main content and sidebar under the top bar. The width of the sidebar and the height of the top bar are also adjusted to prevent inconsistencies.

Fixes: #2679

Testing

  • Open Headlamp and resize the window height to display the scroll bars
  • Ensure that the icons in the side bar are not squished like before, and that the scroll bars are displayed under the top bar

image

@skoeva skoeva added the frontend Issues related to the frontend label Dec 19, 2024
@skoeva skoeva self-assigned this Dec 19, 2024
@skoeva skoeva linked an issue Dec 19, 2024 that may be closed by this pull request
Scrollbar size issue #2679
Open
@skoeva skoeva force-pushed the scrollbar-fix branch 3 times, most recently from 87d25ca to 3e3b634 Compare December 20, 2024 21:41
@skoeva skoeva marked this pull request as ready for review December 20, 2024 21:41
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@skoeva skoeva requested a review from a team December 20, 2024 21:46
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 23, 2024
skoeva added 2 commits January 10, 2025 13:38
@skoeva
frontend: Sidebar: Display scroll bar under top bar
b4a09d2 
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva
frontend: themes: Set fixed toolbar height
1d25bef 
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva skoeva force-pushed the scrollbar-fix branch 2 times, most recently from f3f5aee to 1d65c41 Compare January 10, 2025 19:51
skoeva added 2 commits January 10, 2025 15:08
@skoeva
frontend: Layout: Display main scroll bar under top bar
f0e35fa 
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva
frontend: Sidebar: Resize sidebar when overflowing
dc50e7b 
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniok sniok sniok left review comments

Assignees

@skoeva skoeva

Labels
frontend Issues related to the frontend size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollbar size issue
2 participants
@skoeva @sniok