Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: Remember zoom level after restarts #2746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

app: Remember zoom level after restarts #2746

wants to merge 1 commit into from

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Jan 13, 2025 •
edited
Loading

This change refactors the zoom functionality in the Electron app to remember the zoom level in the Electron app after restarts.

Fixes: #2681

Testing

  • Open the app and change the zoom (i.e. max zoom)
  • Close and restart the app
  • Ensure that the zoom persists from the previous session

@skoeva skoeva added enhancement New feature or request desktop Issues related to the desktop labels Jan 13, 2025
@skoeva skoeva self-assigned this Jan 13, 2025
@skoeva skoeva linked an issue Jan 13, 2025 that may be closed by this pull request
Set a fixed application size #2681
Open
@skoeva skoeva marked this pull request as ready for review January 13, 2025 15:52
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 13, 2025
@skoeva skoeva requested a review from a team January 13, 2025 15:52
@joaquimrocha
Copy link
Collaborator

@skoeva I just tried reproducing the original issue on WSL and I couldn't. After trying a couple of things, turns out the zoom is kept if we use the npm run dev-only-app, which doesn't load the HTML as with the built app but uses the running processes. Still I am puzzled that it initializes the web view in that new process anyway but apparently keeps the zoom... Anyway, maybe worth investigating in case the fix has a less manual solution.

@skoeva skoeva marked this pull request as draft January 15, 2025 15:02
@skoeva skoeva force-pushed the remember-zoom branch 2 times, most recently from 7dbde4d to 4775165 Compare January 15, 2025 23:55
@skoeva
Copy link
Contributor Author

skoeva commented Jan 15, 2025

Looks like we cannot modify the zoom functionality with the existing setup, refactored the logic within the app file to address this

@skoeva skoeva marked this pull request as ready for review January 15, 2025 23:59
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@skoeva
app: Remember zoom level after restarts
c15bf83 
This change refactors the zoom functionality in the Electron app to
remember the zoom level in the Electron app after restarts.

Fixes: #2681

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>

change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skoeva skoeva

Labels
desktop Issues related to the desktop enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set a fixed application size
2 participants
@skoeva @joaquimrocha