backend: Prevent flashing terminal on Windows #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimrocha
force-pushed
the
no-terminal-windows
branch
from
daf3890 to
2080422
Compare
dosubot
bot
added
the
size:XL
joaquimrocha
force-pushed
the
no-terminal-windows
branch
from
2080422 to
857c4fe
Compare
|
Backend Code coverage changed from 63.8% to 59.9%. Change: -3.9% 😞. Coverage report |
joaquimrocha
force-pushed
the
no-terminal-windows
branch
from
857c4fe to
0655313
Compare
|
Backend Code coverage changed from 63.8% to 59.9%. Change: -3.9% 😞. Coverage report |
I will try to add the exec_test.go from upstream. |
joaquimrocha
force-pushed
the
no-terminal-windows
branch
from
0655313 to
608f139
Compare
dosubot
bot
added
size:XXL
|
Backend Code coverage changed from 63.8% to 64.9%. Change: 1.1% 😃. Coverage report |
|
Tested using Azure AKS cluster with Entra ID that executes azure-cli kubeconfigCan confirm that it doesn't open terminal windows anymore. |
yolossn
reviewed
Jan 22, 2025
joaquimrocha
force-pushed
the
no-terminal-windows
branch
from
608f139 to
e1268cf
Compare
|
Backend Code coverage changed from 63.8% to 64.9%. Change: 1.1% 😃. Coverage report |
On Windows, even when the exec plugin's command is not interactive, running the command was still making the terminal window flash (default behavior on Windows). This can be annoying if a tool runs the exec plugin frequently. This patch prevents that problem by setting a sys proc attribute to hide windows, only when in the Windows platform and when the exec is non-interactive. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
joaquimrocha
force-pushed
the
no-terminal-windows
branch
from
e1268cf to
125697b
Compare
yolossn
approved these changes
Jan 22, 2025
|
Backend Code coverage changed from 63.8% to 64.9%. Change: 1.1% 😃. Coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, even when the exec plugin's command is not interactive, running the command was still making the terminal window flash (default behavior on Windows). This can be annoying if a tool runs the exec plugin frequently. This patch prevents that problem by setting a sys proc attribute to hide windows, only when in the Windows platform and when the exec is non-interactive.
How to test:
On Windows:
CreateEmptyFile.cmdscript in your home folder:On non-Windows:
fixes #2346