Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Fix namespace selection when allowed namespaces is set #2775

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Jan 23, 2025

By default if user has 'allowed namespaces' and no namespaces selected in the dropdown, it should load only the 'allowed namespaces'

This case wasn't handled properly and would just pass empty array for namespaces which would load all namespaces.

By default if user has 'allowed namespaces' and no namespaces selected
in the dropdown, it should load only the 'allowed namespaces'

This case wasn't handled properly and would just pass empty array for
namespaces which would load all namespaces.

Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@joaquimrocha joaquimrocha merged commit 2fe8982 into main Jan 23, 2025
18 checks passed
@joaquimrocha joaquimrocha deleted the allowed-namespaces-fix branch January 23, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants