Revert "Merge pull request #2615 from farodin91/refactor-settings-cluster" #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
sniok
force-pushed
the
revert-settings-refactor
branch
from
6de6de9 to
7c6798d
Compare
illume
added
bug
|
For the release, it makes sense to revert. Let's figure out what was the actual issue was after we have the new version out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 39d8f72, reversing changes made to f5dc9fd.
This fixes cluster settings
How to test
Type something in default namespace, make sure page isn't replaced by a spinner
Select default namespace, switch to a different cluster, make sure the default namespace values updates accordingly