base and main dockerfiles, and base- and main-building gha workflows - defunct #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targetted for long-running server process via deploy stage ATM
quirky-looking values used for non-production represent previous state of devise config (including devise defaults in https://github.com/heartcombo/devise/blob/v3.3.0/lib/devise.rb). old secret_key val is left for non-prod, to not cause issues with creds in local db's.
brianhenryhf
force-pushed
the
188414578-dockerfile
branch
from
0184e92 to
6d36ae8
Compare
brianhenryhf
changed the title
brianhenryhf
changed the title
brianhenryhf
changed the title
brianhenryhf
force-pushed
the
188414578-dockerfile
branch
from
f0efb14 to
79cf277
Compare
brianhenryhf
changed the title
|
closed to open a new PR, to open up PR review possibilities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/2663780/stories/188414578#
https://www.pivotaltracker.com/n/projects/2663780/stories/188414579#
Adds "base" image Dockerfile, and the main source of end build targets (
deploy,update,reports) to be run by GHA,Dockerfile.gha. Also includes GHA workflows handling the build of base and thedeploytarget, as these are a priority for testing.Keeps most standard Rails config in the core repo, with key values changeable via env variables. Currently, puts scripts and a config override for a separate repo, all used by the
updateimage, in.docker/config. The latter is consistent with other glue repos, and avoids editing the complex (and difficult to test)updatescript process.