Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base and main dockerfiles, and base- and main-building gha workflows #171

Merged
merged 26 commits into from
Nov 15, 2024

Conversation

brianhenryhf
Copy link

@brianhenryhf brianhenryhf commented Nov 14, 2024

https://www.pivotaltracker.com/n/projects/2663780/stories/188414578#
https://www.pivotaltracker.com/n/projects/2663780/stories/188414579#
https://www.pivotaltracker.com/n/projects/2663780/stories/188431432#

Adds "base" image Dockerfile, and the main source of end build targets (deploy, update, reports) to be run by GHA, Dockerfile.gha. Also includes GHA workflows handling the build of base and the deploy target, as these are a priority for testing.

Keeps most standard Rails config in the core repo, with key values changeable via env variables. Currently, puts scripts and a config override for a separate repo, all used by the update image, in .docker/config. The latter is consistent with other glue repos, and avoids editing the complex (and difficult to test) update script process.

polographer and others added 26 commits November 5, 2024 12:28
targetted for long-running server process via deploy stage ATM
quirky-looking values used for non-production represent previous state of devise config (including devise defaults in https://github.com/heartcombo/devise/blob/v3.3.0/lib/devise.rb).

old secret_key val is left for non-prod, to not cause issues with creds in local db's.
Copy link

@kvootla kvootla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good.

@polographer polographer merged commit 34e9fcf into master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants