Add bein hashmashos #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added bein hashmashos zman calculated as 13.5 minutes before a solar depression of 7.083 degrees
Added test for zman bein hashmashos
Added zman bein hashmashos to zmanim list Removed dawn and dusk
Added test units zman bein hashmashos Removed test units for dawn and dusk
Added missing comma at end of bein hashmashos test unit
added missing comma in bein hashmashos test unit
added bein hashmashos test unit removed dawn and dusk test units
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update zmanim.go to compute zman bein hashmashos as 13.5 minutes before tzies3mediumstars
update candles.go to include this in zmanim listed with -Z flag
remove civil dawn and civil dusk from list
add test units to zmanim_test.go and hebcal_test.go