fix phpstan test

heimrichhannot · Oct 20, 2023 · e826bcf · e826bcf
1 parent 9818e65
commit e826bcf
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/Util/User/UserUtil.php b/src/Util/User/UserUtil.php
@@ -37,15 +37,19 @@ public function __construct(
 
     public function findActiveUsersByGroup(array $groups, string $type = self::TYPE_USER, array $options = []): ?Collection
     {
-        match ($type) {
-            self::TYPE_USER => $table = UserModel::getTable(),
-            self::TYPE_MEMBER => $table = MemberModel::getTable(),
+        $table = match ($type) {
+            self::TYPE_USER => UserModel::getTable(),
+            self::TYPE_MEMBER => MemberModel::getTable(),
             default => throw new \InvalidArgumentException(sprintf('Invalid type "%s" given.', $type)),
         };
 
         /** @var class-string<Model> $modelClass */
         $modelClass = $this->contaoFramework->getAdapter(Model::class)->getClassFromTable($table);
 
+        if (!$modelClass) {
+            return null;
+        }
+
         if (!\is_array($groups) || empty($groups = array_filter($groups, function ($k) {
                 return !empty($k) && is_numeric($k);
             }))) {
@@ -82,8 +86,6 @@ public function getActiveGroups(UserModel|MemberModel $user): ?Collection
             $groupTable = 'tl_user_group';
         }
 
-//        $groupTable = $user::getTable() .'_group';
-
         $columns = [$groupTable.'.id IN('.implode(',', array_map('\intval', $groups)).')'];
 
         $this->modelUtil->addPublishedCheckToModelArrays($groupTable, $columns, [