enhance test coverage

heimrichhannot · Nov 15, 2024 · fd9945f · fd9945f
1 parent 279f619
commit fd9945f
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 25 deletions.
diff --git a/src/Util/Ui/PopupWizardLinkOptions.php b/src/Util/Ui/PopupWizardLinkOptions.php
@@ -90,5 +90,21 @@ public function setLinkText(string $linkText): PopupWizardLinkOptions
         return $this;
     }
 
+    /**
+     * Set the title of the popup.
+     */
+    public function setPopupTitle(string $string): PopupWizardLinkOptions
+    {
+        $this->popupTitle = $string;
+        return $this;
+    }
 
+    /**
+     * Set the width of the popup.
+     */
+    public function setWidth(int $width): PopupWizardLinkOptions
+    {
+        $this->width = $width;
+        return $this;
+    }
 }
diff --git a/src/Util/Utils.php b/src/Util/Utils.php
@@ -48,6 +48,11 @@ public function array(): ArrayUtil
         return $this->locator->get(ArrayUtil::class);
     }
 
+    public function backendUi(): BackendUiUtil
+    {
+        return $this->locator->get(BackendUiUtil::class);
+    }
+
     public function class(): ClassUtil
     {
         return $this->locator->get(ClassUtil::class);
@@ -118,6 +123,7 @@ public static function getSubscribedServices()
         return [
             AccordionUtil::class,
             ArrayUtil::class,
+            BackendUiUtil::class,
             ClassUtil::class,
             ContainerUtil::class,
             DatabaseUtil::class,

diff --git a/tests/Util/BackendUiUtilTest.php b/tests/Util/BackendUiUtilTest.php
@@ -17,7 +17,7 @@ public function getTestInstance(array $parameters = [], ?MockBuilder $mockBuilde
     {
         $parameters['routingUtil'] = $parameters['routingUtil'] ?? $this->createMock(RoutingUtil::class);
         $parameters['framework'] = $parameters['framework'] ?? $this->createMock(ContaoFramework::class);
-        $parameters['htmlUtil'] = $parameters['htmlUtil'] ?? $this->createMock(HtmlUtil::class);
+        $parameters['htmlUtil'] = $parameters['htmlUtil'] ?? new HtmlUtil();
 
         return new BackendUiUtil($parameters['routingUtil'], $parameters['framework'], $parameters['htmlUtil']);
     }
@@ -31,43 +31,53 @@ public function testPopupWizardLinkReturnsCorrectUrlOnly()
         $backendUiUtil = $this->getTestInstance(['routingUtil' => $routingUtil]);
 
         $config = new PopupWizardLinkOptions();
-        $config->urlOnly = true;
+        $config->setUrlOnly(true);
 
-        $result = $backendUiUtil->popupWizardLink(['param' => 'value'], $config);
-
-        $this->assertEquals('generated_url', $result);
+        $this->assertEquals(
+            'generated_url',
+            $backendUiUtil->popupWizardLink(['param' => 'value'], $config)
+        );
     }
 
     public function testPopupWizardLinkGeneratesCorrectLink()
     {
         $routingUtil = $this->createMock(RoutingUtil::class);
-        $htmlUtil = $this->createMock(HtmlUtil::class);
 
         $routingUtil->method('generateBackendRoute')->willReturn('generated_url');
-        $htmlUtil->method('generateAttributeString')->willReturn('title="Test Title" style="Test Style" onclick="Test Onclick"');
-
-        $backendUiUtil = $this->getTestInstance(['routingUtil' => $routingUtil, 'htmlUtil' => $htmlUtil]);
 
-        $config = new PopupWizardLinkOptions();
-        $config->title = 'Test Title';
-        $config->style = 'Test Style';
-        $config->popupTitle = 'Test Popup Title';
-        $config->width = 800;
-        $config->linkText = 'Test Link Text';
-
-        $result = $backendUiUtil->popupWizardLink(['param' => 'value'], $config);
+        $backendUiUtil = $this->getTestInstance(['routingUtil' => $routingUtil]);
 
-        $this->assertStringContainsString('<a href="generated_url" title="Test Title" style="Test Style" onclick="Test Onclick">Test Link Text</a>', $result);
+        $config = (new PopupWizardLinkOptions())
+            ->setTitle('Test Title')
+            ->setStyle('border: 0;')
+            ->setPopupTitle('Test Popup Title')
+            ->setWidth(800)
+            ->setLinkText('Test Link Text');
+        ;
+
+        $this->assertStringContainsString(
+            '<a href="generated_url" title="Test Title" style="border: 0;" onclick="Backend.openModalIframe({\'width\':800,\'title\':\'Test Popup Title\',\'url\':this.href});return false">Test Link Text</a>',
+            $backendUiUtil->popupWizardLink(['param' => 'value'], $config)
+        );
+
+        $GLOBALS['TL_LANG']['tl_content']['edit'][0] = 'Edit';
+        $config->title = '';
+        $this->assertStringContainsString(
+            '<a href="generated_url" title="Edit" style="border: 0;" onclick="Backend.openModalIframe({\'width\':800,\'title\':\'Test Popup Title\',\'url\':this.href});return false">Test Link Text</a>',
+            $backendUiUtil->popupWizardLink(['param' => 'value'], $config)
+        );
+
+        $config->popupTitle = '';
+        $this->assertStringContainsString(
+            '<a href="generated_url" title="Edit" style="border: 0;" onclick="Backend.openModalIframe({\'width\':800,\'title\':\'Edit\',\'url\':this.href});return false">Test Link Text</a>',
+            $backendUiUtil->popupWizardLink(['param' => 'value'], $config)
+        );
     }
 
     public function testPopupWizardLinkGeneratesLinkWithIcon()
     {
         $routingUtil = $this->createMock(RoutingUtil::class);
-        $framework = $this->createMock(ContaoFramework::class);
-        $htmlUtil = $this->createMock(HtmlUtil::class);
-
         $routingUtil->method('generateBackendRoute')->willReturn('generated_url');
-        $htmlUtil->method('generateAttributeString')->willReturn('title="Test Title" style="Test Style" onclick="Test Onclick"');
 
         $image = $this->mockAdapter(['getHtml']);
         $image->method('getHtml')->willReturn('<img src="alias.svg" alt="Test Title" style="vertical-align:top">');
@@ -81,9 +91,11 @@ public function testPopupWizardLinkGeneratesLinkWithIcon()
         $config->linkText = 'Test Link Text';
         $config->icon = 'alias.svg';
 
-        $backendUiUtil = new BackendUiUtil($routingUtil, $framework, $htmlUtil);
-        $result = $backendUiUtil->popupWizardLink(['param' => 'value'], $config);
+        $backendUiUtil = $this->getTestInstance(['routingUtil' => $routingUtil, 'framework' => $framework]);
 
-        $this->assertStringContainsString('<a href="generated_url" title="Test Title" style="Test Style" onclick="Test Onclick"><img src="alias.svg" alt="Test Title" style="vertical-align:top"> Test Link Text</a>', $result);
+        $this->assertStringContainsString(
+            '<a href="generated_url" title="Test Title" style="Test Style" onclick="Backend.openModalIframe({\'width\':800,\'title\':\'Test Popup Title\',\'url\':this.href});return false"><img src="alias.svg" alt="Test Title" style="vertical-align:top"> Test Link Text</a>',
+            $backendUiUtil->popupWizardLink(['param' => 'value'], $config)
+        );
     }
 }
diff --git a/tests/Util/UtilsTest.php b/tests/Util/UtilsTest.php
@@ -9,6 +9,7 @@
 namespace HeimrichHannot\UtilsBundle\Tests\Util;
 
 use Contao\TestCase\ContaoTestCase;
+use HeimrichHannot\UtilsBundle\Util\BackendUiUtil;
 use HeimrichHannot\UtilsBundle\Util\Container\ContainerUtil;
 use HeimrichHannot\UtilsBundle\Util\Dca\DcaUtil;
 use HeimrichHannot\UtilsBundle\Util\Html\HtmlUtil;
@@ -38,6 +39,9 @@ public function getTestInstance(array $parameter = [])
                     case ArrayUtil::class:
                         return $this->createMock(ArrayUtil::class);
 
+                    case BackendUiUtil::class:
+                        return $this->createMock(BackendUiUtil::class);
+
                     case ContainerUtil::class:
                         return $this->createMock(ContainerUtil::class);
 
@@ -86,6 +90,11 @@ public function testArray()
         $this->assertInstanceOf(ArrayUtil::class, $this->getTestInstance()->array());
     }
 
+    public function testBackendUi()
+    {
+        $this->assertInstanceOf(BackendUiUtil::class, $this->getTestInstance()->backendUi());
+    }
+
     public function testContainer()
     {
         $this->assertInstanceOf(ContainerUtil::class, $this->getTestInstance()->container());