Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance entity finder #87

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Enhance entity finder #87

merged 8 commits into from
Jan 6, 2025

Conversation

koertho
Copy link
Contributor

@koertho koertho commented Nov 26, 2024

No description provided.

@koertho koertho changed the base branch from v3 to v2 November 26, 2024 07:59
@coveralls
Copy link

coveralls commented Dec 4, 2024

Pull Request Test Coverage Report for Build 12632930366

Details

  • 96 of 154 (62.34%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 25.158%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Event/EntityFinderFindEvent.php 3 7 42.86%
src/EntityFinder/Finder.php 83 92 90.22%
src/EntityFinder/EntityFinderHelper.php 0 20 0.0%
src/Command/EntityFinderCommand.php 2 27 7.41%
Totals Coverage Status
Change from base Build 12177640826: 1.1%
Covered Lines: 1475
Relevant Lines: 5863

💛 - Coveralls

@koertho koertho force-pushed the feature/entity_finder_forms branch from 0a710d9 to fda9684 Compare December 9, 2024 10:06
@koertho koertho changed the base branch from v2 to v3 December 9, 2024 10:48
@koertho koertho changed the base branch from v3 to v2 December 9, 2024 10:49
@koertho koertho merged commit 98b0589 into v2 Jan 6, 2025
10 checks passed
@koertho koertho deleted the feature/entity_finder_forms branch January 6, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants