Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): missing packages use min required and peerDep shoud use latest version #121

Merged
merged 3 commits into from
Dec 8, 2024
Merged

fix(upgrade): missing packages use min required and peerDep shoud use latest version #121

merged 3 commits into from
Dec 8, 2024

Conversation

winchesHe
Copy link
Member

@winchesHe winchesHe commented Dec 7, 2024 •
edited
Loading

📝 Description

Before

image

After

Cursor 2024-12-08 13 43 36

✅ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Improvement (non-breaking change which improves an existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

@winchesHe winchesHe changed the title fix: upgrade missing packages not using latest version fix: upgrade missing packages not to use latest version Dec 7, 2024
@jrgarciadev
Copy link
Member

I see the "theme" package is in the same 2.3.0? please check

@winchesHe
Copy link
Member Author

I see the "theme" package is in the same 2.3.0? please check

Fixed, current peerDependencies will also upgrade to latest version not required version

@winchesHe winchesHe changed the title fix: upgrade missing packages not to use latest version fix(upgrade): missing packages use min required and peerDep shoud use latest version Dec 8, 2024
@winchesHe
Copy link
Member Author

https://linear.app/nextui-inc/issue/ENG-1669/fetch-the-latest-version-of-the-peerdep

1 similar comment
@winchesHe
Copy link
Member Author

https://linear.app/nextui-inc/issue/ENG-1669/fetch-the-latest-version-of-the-peerdep

@jrgarciadev jrgarciadev merged commit a81e24b into main Dec 8, 2024
3 checks passed
@jrgarciadev jrgarciadev deleted the fix/upgrade-not-latest-missing-version branch December 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev jrgarciadev approved these changes

@tianenpang tianenpang Awaiting requested review from tianenpang tianenpang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winchesHe @jrgarciadev