Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cropped text in macOS Big Sur status bar #110

Closed
wants to merge 1 commit into from

Conversation

johnothwolo
Copy link

This fixes the cropped out text when the "multiline" option is selected (issue #109).

This fixes the cropped out text when the "multiline" option is selected  (issue hholtmann#109).
@johnothwolo
Copy link
Author

johnothwolo commented Sep 7, 2020

Reference https://stackoverflow.com/a/26561522

@ghost
Copy link

ghost commented Nov 14, 2020

How can I install your version?

@kenrickles
Copy link

kenrickles commented Nov 15, 2020

@johnothwolo Hi there, could You compile a version for us?
Or maybe could You give instructions to compile?

@ghost
Copy link

ghost commented Nov 15, 2020

@kenrickles to compile I'm not pretty sure but I think you need to do (in the repo's directory)

xcodebuild install

But with the fact Xcode being 12+ GB and that I have a limited storage, I think I'll pass at least these days, hopefully the OP provides alternatives to install.

@kenrickles
Copy link

@emadboctorx I tried building it on Xcode and I faced issues like ld: 4 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

kinda gave up and will be patient I guess.

@ghost
Copy link

ghost commented Nov 15, 2020

@kenrickles check here

@strafe
Copy link

strafe commented Nov 18, 2020

@kenrickles you just need to declare fannum as a static variable.

UInt8 fannum[] = "0123456789ABCDEFGHIJ";

to

static UInt8 fannum[] = "0123456789ABCDEFGHIJ"; 

@johnothwolo
Copy link
Author

johnothwolo commented Nov 19, 2020

For anybody else I built an unofficial release with the fix here

@ghost
Copy link

ghost commented Nov 19, 2020

@johnothwolo just curious, did you build it using xcodebuild install? Or is there another way? And many thanks

@kenrickles
Copy link

@johnothwolo thank You so much!

@kenrickles
Copy link

kenrickles commented Nov 20, 2020

@kenrickles you just need to declare fannum as a static variable.

UInt8 fannum[] = "0123456789ABCDEFGHIJ";

to

static UInt8 fannum[] = "0123456789ABCDEFGHIJ"; 

Think I will give it a try. I just started programming about 1 month ago. Not too familiar with C++ or swift or Xcode.
Am currently coding base on javascript and nodejs. but thank You!

@Mike-Woolley
Copy link
Contributor

Hi @johnothwolo, unfortunately this change breaks the "single line" option.

I fixed it by restricting the change to the "multi-line" option with:

if (menuBarSetting == 0) {

Thanks

Mike-Woolley added a commit to Mike-Woolley/smcFanControl that referenced this pull request Dec 19, 2020
hholtmann#110

Also fixed a bug in the PR which broke the "single-line" display option.
@johnothwolo
Copy link
Author

I was so spear focused on the double line issue, I didn't even test single. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants