chore(feat): TokenRejectFlow refactor
#2823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
agadzhalov
previously approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
0xivanov
commented
Jan 24, 2025
ivaylogarnev-limechain
previously approved these changes
Jan 24, 2025
0xivanov
changed the title
TokenRejectFlow refactorTokenRejectFlow refactor
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
0xivanov
dismissed stale reviews from ivaylogarnev-limechain and agadzhalov
via
f493916
ivaylogarnev-limechain
previously approved these changes
Jan 24, 2025
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
TokenRejectFlowclass and similar transaction flows are overly reliant on class hierarchies that treat flows as if they are transactions themselves. This design complicates the implementation and maintenance of transaction flows.This PR does not change the API, but only adds getters to allow modification to the individual transactions.