Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-1746 | Loans Smart navigation #1060

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

PSR-1746 | Loans Smart navigation #1060

wants to merge 11 commits into from

Conversation

Neozxc
Copy link
Contributor

@Neozxc Neozxc commented Jan 22, 2025

Dev Tasks:

  • If a user adds a new loan, progresses in the journey, leaves to the main loans page, and adds another loan, they're redirected back to where they left off in the journey
  • Make sure unit tests pass
  • Make sure the pipe is green

@platops-pr-bot
Copy link

  • There is a bobby warning (builds will be prevented after 14 Jul 2025) - see the pr builder for details

kberec
kberec reviewed Jan 23, 2025
View reviewed changes
app/controllers/nonsipp/common/CompanyRecipientCrnController.scala Show resolved Hide resolved
app/controllers/nonsipp/common/CompanyRecipientCrnController.scala Outdated Show resolved Hide resolved
app/controllers/nonsipp/common/OtherRecipientDetailsController.scala Outdated Show resolved Hide resolved
app/controllers/nonsipp/common/PartnershipRecipientUtrController.scala Outdated Show resolved Hide resolved
app/controllers/nonsipp/employercontributions/EmployerContributionsMemberListController.scala Show resolved Hide resolved
app/controllers/nonsipp/loansmadeoroutstanding/AmountOfTheLoanController.scala Show resolved Hide resolved
app/transformations/LoansTransformer.scala Show resolved Hide resolved
app/controllers/nonsipp/loansmadeoroutstanding/RemoveLoanController.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kberec kberec kberec left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neozxc @platops-pr-bot @kberec