Just cleaned a bit.

hojat72elect · May 24, 2024 · dea35d8 · dea35d8
1 parent e98568e
commit dea35d8
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -60,14 +60,14 @@ https://user-images.githubusercontent.com/14782808/111520365-b187a880-8760-11eb-
 ### Screenshots
 
 <p>
-<img src="/media/screenshot1.png" width="32%"/>
-<img src="/media/screenshot2.png" width="32%"/>
-<img src="/media/screenshot3.png" width="32%"/>
-</p>
-<p>
-<img src="/media/screenshot4.png" width="32%"/>
-<img src="/media/screenshot5.png" width="32%"/>
-<img src="/media/screenshot6.png" width="32%"/>
+<img src="/media/screenshot1.png" width="32%" alt="An screen shot of the app"/>
+<img src="/media/screenshot2.png" width="32%" alt="An screen shot of the app"/>
+<img src="/media/screenshot3.png" width="32%" alt="An screen shot of the app"/>
+</p> 
+<p> 
+<img src="/media/screenshot4.png" width="32%" alt="An screen shot of the app"/>
+<img src="/media/screenshot5.png" width="32%" alt="An screen shot of the app"/>
+<img src="/media/screenshot6.png" width="32%" alt="An screen shot of the app"/>
 </p>
 
 ## Tech Stack

diff --git a/app/src/main/java/ca/hojat/gamehub/GameHubApplication.kt b/app/src/main/java/ca/hojat/gamehub/GameHubApplication.kt
@@ -2,10 +2,9 @@ package ca.hojat.gamehub
 
 import android.app.Application
 import ca.hojat.gamehub.initializers.Initializer
-import ca.hojat.gamehub.BuildConfig
 import dagger.hilt.android.HiltAndroidApp
-import timber.log.Timber
 import javax.inject.Inject
+import timber.log.Timber
 
 @HiltAndroidApp
 class GameHubApplication : Application() {

diff --git a/app/src/main/java/ca/hojat/gamehub/common_ui/theme/Typography.kt b/app/src/main/java/ca/hojat/gamehub/common_ui/theme/Typography.kt
@@ -57,6 +57,10 @@ private val SUBTITLE_3 = TextStyle(
     letterSpacing = 0.50.sp,
 )
 
+/**
+ * WARNING : I have no idea why linter considers this as a warning. This extension value has been used in
+ * various places. Do not remove it. Better to just disable the corresponding inspection in Android Studio.
+ */
 @Suppress("unused")
 val Typography.subtitle3: TextStyle
     get() = SUBTITLE_3
diff --git a/app/src/main/java/ca/hojat/gamehub/core/data/auth/datastores/file/ProtoUtils.kt b/app/src/main/java/ca/hojat/gamehub/core/data/auth/datastores/file/ProtoUtils.kt
@@ -1,7 +1,6 @@
 package ca.hojat.gamehub.core.data.auth.datastores.file
 
 import androidx.datastore.core.Serializer
-import ca.hojat.gamehub.core.data.auth.datastores.file.NewProtoOauthCredentials
 import java.io.InputStream
 import java.io.OutputStream
 
@@ -14,7 +13,6 @@ fun NewProtoOauthCredentials.isNotEmpty(): Boolean {
             )
 }
 
-@Suppress("BlockingMethodInNonBlockingContext")
 object ProtoOauthCredentialsSerializer : Serializer<NewProtoOauthCredentials> {
 
     override val defaultValue: NewProtoOauthCredentials

diff --git a/...rc/main/java/ca/hojat/gamehub/feature_settings/data/datastores/ProtoSettingsSerializer.kt b/...rc/main/java/ca/hojat/gamehub/feature_settings/data/datastores/ProtoSettingsSerializer.kt
@@ -1,12 +1,10 @@
 package ca.hojat.gamehub.feature_settings.data.datastores
 
 import androidx.datastore.core.Serializer
-import ca.hojat.gamehub.feature_settings.data.datastores.ProtoSettings
 import ca.hojat.gamehub.feature_settings.domain.DomainSettings
 import java.io.InputStream
 import java.io.OutputStream
 
-@Suppress("BlockingMethodInNonBlockingContext")
 internal object ProtoSettingsSerializer : Serializer<ProtoSettings> {
 
     override val defaultValue: ProtoSettings

diff --git a/app/src/test/java/ca/hojat/gamehub/feature_settings/data/SettingsFileDataSourceTest.kt b/app/src/test/java/ca/hojat/gamehub/feature_settings/data/SettingsFileDataSourceTest.kt
@@ -48,12 +48,4 @@ internal class SettingsFileDataSourceTest {
         }
     }
 
-    @Test
-    fun `Observes settings successfully`() {
-        runTest {
-            coEvery { protoDataStore.data } returns flowOf(PROTO_SETTINGS)
-
-            assertThat(sut.observeSettings().first()).isEqualTo(DOMAIN_SETTINGS)
-        }
-    }
 }