Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/843 provide task list filter criteria #335

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

p-wunderlich
Copy link
Contributor

@p-wunderlich p-wunderlich commented Jul 3, 2024

Should be done AFTER #323 and new Polyflow release is needed

@zambrovski zambrovski self-requested a review January 24, 2025 08:51
@zambrovski zambrovski added this to the 4.1.0 milestone Jan 24, 2025
@zambrovski
Copy link
Member

I didn't quite got it. The referenced PR of polyflow was merged but still, I had to fix some compilation errors. On doing so, I realized that the two relevant queries are now missing filters in polyflow... So adopted it in the example code, but then, we should probably adopt in in the Open API too...

Please have a look again, @p-wunderlich ... I'll mark the relevant places in the review

'/tasks/payload/attribute/names':
parameters:
- $ref: '#/components/parameters/CurrentUserIdParam'
- $ref: '#/components/parameters/FiltersParam'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no filters in the api anymore

parameters:
- $ref: '#/components/parameters/CurrentUserIdParam'
- $ref: '#/components/parameters/AttributeNameParam'
- $ref: '#/components/parameters/FiltersParam'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No filters in the API

override fun getTasksAttributeValues(
xCurrentUserID: String,
attributeName: String,
filters: List<String>? // FIXME -> no filters needed?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you see, the generated method signature is not matching the API call in line 169

.query(
TaskAttributeNamesQuery(
user = user,
assignedToMeOnly = false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because there are no filters in the query object

TaskAttributeValuesQuery(
attributeName = attributeName,
user = user,
assignedToMeOnly = false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because there are no filters in the query object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants