Check before executing unsupported action

[DCSBL]

This reduces unnecessary calls to the device when we already know the device has no support for it.

Summary by CodeRabbit

• Bug Fixes

  • Updated error handling for state and reboot methods to provide clearer unsupported functionality messages
  • Improved device support checks in state and identify methods

• Refactor

  • Removed constants related to state and identify support
  • Updated test suite to handle new error types

• Tests

  • Enhanced test cases to validate new error handling mechanisms

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces changes to the HomeWizard Energy library, focusing on error handling and method support checks. The modifications primarily affect the base and V1 implementation classes, updating how unsupported methods are handled. The changes replace NotImplementedError with UnsupportedError for specific methods like state and reboot, and remove some constants related to device support. The test suite is also updated to reflect these changes, ensuring proper exception handling for different method calls.

Changes

File	Change Summary
homewizard_energy/homewizard_energy.py	- Updated state method to raise UnsupportedError instead of NotImplementedError - Updated reboot method to raise UnsupportedError instead of NotImplementedError
homewizard_energy/v1/__init__.py	- Enhanced state method with docstring update - Added support checks in state and identify methods - Introduced early exits for unsupported device functionality
homewizard_energy/v1/const.py	- Removed SUPPORTS_STATE constant - Removed SUPPORTS_IDENTIFY constant
tests/test_homewizard_energy.py	- Added import for UnsupportedError - Updated test function to handle different exceptions - Modified test cases to use dynamic exception checking

Sequence Diagram

sequenceDiagram
    participant Client
    participant HomeWizardEnergyV1
    participant Device

    Client->>HomeWizardEnergyV1: Call state() or identify()
    HomeWizardEnergyV1->>Device: Check device support
    alt Device not supported
        HomeWizardEnergyV1-->>Client: Raise UnsupportedError
    else Device supported
        HomeWizardEnergyV1->>Device: Proceed with operation
        Device-->>HomeWizardEnergyV1: Return result
        HomeWizardEnergyV1-->>Client: Return result
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27467b8 and 7eeb860.

📒 Files selected for processing (4)

• homewizard_energy/homewizard_energy.py (2 hunks)
• homewizard_energy/v1/__init__.py (2 hunks)
• homewizard_energy/v1/const.py (0 hunks)
• tests/test_homewizard_energy.py (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.14%. Comparing base (27467b8) to head (7eeb860).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
homewizard_energy/v1/__init__.py	0.00%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   95.49%   95.14%   -0.36%     
==========================================
  Files           9        8       -1     
  Lines         533      535       +2     
  Branches       37       39       +2     
==========================================
  Hits          509      509              
  Misses         17       17              
- Partials        7        9       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.