Remove handing of non-200 in v1 state/system calls, already handled by _request

[DCSBL]

Summary by CodeRabbit

• Refactor
  • Simplified response handling in the API client
  • Streamlined error management for API requests
  • Removed redundant status code checks in method calls

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the HomeWizardEnergyV1 class in the homewizard_energy/v1/__init__.py file. The changes primarily simplify the response handling in the system, state, and measurement methods by removing explicit status checks and streamlining the response unpacking process. The modifications reduce the complexity of error handling related to HTTP status codes while maintaining the overall structure of the methods.

Changes

File	Change Summary
homewizard_energy/v1/__init__.py	- Removed status variable from response unpacking in system, state, and measurement methods - Simplified response handling by directly unpacking responses - Retained error handling for unsupported fields - Removed legacy status-based RequestError exceptions

Possibly related PRs

• Use native arguments for set-functions and route led_brightness to state for v1 API #460: Changes to the HomeWizardEnergyV1 class methods system and state, suggesting similar approaches to handling method parameters and responses

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3323ca and 6f0fe13.

📒 Files selected for processing (1)

• homewizard_energy/v1/__init__.py (2 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (a3323ca) to head (6f0fe13).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   97.77%   98.50%   +0.73%     
==========================================
  Files           8        8              
  Lines         539      535       -4     
  Branches       39       37       -2     
==========================================
  Hits          527      527              
+ Misses          7        5       -2     
+ Partials        5        3       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.