Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat project creation #71

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Feat project creation #71

merged 8 commits into from
Jul 15, 2024

Conversation

Pradip-p
Copy link
Collaborator

Description

This PR introduces several enhancements and fixes to the project schema:

  1. New Features:

    • Deadline Column: Added a new deadline column to the projects table to track submission deadlines.
    • No Fly Zones Support: Enhanced the no_fly_zones input to support Polygon, MultiPolygon, and other geometry types, ensuring flexible and accurate representation of restricted areas.
      Additional Schema Fields: Introduced the following new fields to the project schema:
      • gsd_cm_px
      • is_terrain_follow
      • outline_no_fly_zones
      • output_orthophoto_url
      • output_pointcloud_url
      • output_raw_url
      • deadline
  2. Utility Functions:

    • Added a multipolygon_to_polygon utility function to handle and convert multipolygon geometries within no_fly_zones.

@Pradip-p Pradip-p requested review from nrjadkry and spwoodcock July 13, 2024 09:35
@spwoodcock
Copy link
Member

spwoodcock commented Jul 13, 2024

Always good db practice to at _at for date columns, so deadline_at 😄

@Pradip-p
Copy link
Collaborator Author

Always good db practice to at _at for date columns, so deadline_at 😄
@spwoodcock Thanks for the feedback! Just updated the column names with '_at' for better clarity. 😄

Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Minor comment: to save listing this huge list of variables to inject, could the ones from project_metadata be inserted simply using **project_metadata?

They will be used as keyword args, so this will work where the variable names match.

It would also make the code more resilient to change / breakage if variables change in future.

values={
"id": _id,
"author_id": author_id,
"name": project_metadata.name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is would work here for example and all vars that match like this

@nrjadkry nrjadkry merged commit 903deb1 into main Jul 15, 2024
2 checks passed
@spwoodcock spwoodcock deleted the feat-project-creation branch July 15, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants