Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add domain routing support #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cvolant
Copy link
Collaborator

@cvolant cvolant commented Mar 1, 2023

The current changes seem to work but don't.

In the example, the api docs link is broken:

  • In fr, it is not translated correctly when multi domain is configured
  • In en, a clic creates a looping redirection event when multi domain is not configured

@cvolant cvolant force-pushed the feat/add-domain-routing-support branch from 998848b to fba2fa0 Compare March 1, 2023 14:21
@cvolant cvolant mentioned this pull request Mar 1, 2023
@nicrodgers
Copy link

I've yet to give this a proper test but will do so over the next few days, as we have a requirement to use domain based routing with translated paths. Have you been using it with any success?
One tiny thing I noticed, is that the README will need to be updated to remove domain routing from the list of unsupported features.

@nicrodgers
Copy link

This does seem to work well with Next 12.
It doesn't work with next 13, but then the main next-translate-routes package says it's not yet next13 compatible, so that makes sense... Will do more testing over the next few days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants